Adding message links to some log messages that were missing them

rocketbot/cogs/crosspostcog.py

@@ -190,8 +190,11 @@ class CrossPostCog(BaseCog, name='Crosspost Detection'):
 			await message.set_reactions([])
 			await message.set_text(text)
 		else:
-			await message.set_text(f'User {context.member.mention} posted ' +
-				f'the same message in {channel_count} channels.')
+			body: str = f'User {context.member.mention} posted ' + \
+				f'the same message in {channel_count} channels.'
+			for msg in context.spam_messages:
+				body += f'\n- {msg.jump_url}'
+			await message.set_text(body)
 			await message.set_reactions(BotMessageReaction.standard_set(
 				did_delete = deleted_count >= spam_count,
 				message_count = spam_count,

rocketbot/cogs/logcog.py

@@ -740,8 +740,6 @@ class LoggingCog(BaseCog, name='Logging'):
 		markdown_b = ''
 		a_open = False
 		b_open = False
-		# FIXME: Handle URLs better. They get mangled.
-		# URL regex: http[s]?://(?:[a-zA-Z]|[0-9]|[$-_@.&+]|[!*\(\),]|(?:%[0-9a-fA-F][0-9a-fA-F]))+
 		for i, s in enumerate(difflib.ndiff(a, b)):
 			operation = s[0]
 			content = s[2:]

rocketbot/cogs/patterncog.py

@@ -153,8 +153,8 @@ class PatternCog(BaseCog, name='Pattern Matching'):
 			bm = BotMessage(
 				message.guild,
 				f'User {message.author.name} tripped custom pattern ' + \
-					f'`{statement.name}`.\n\nAutomatic actions taken:\n• ' + \
-					('\n• '.join(action_descriptions)),
+					f'`{statement.name}` at {message.jump_url}.\n\n' + \
+					'Automatic actions taken:\n• ' + ('\n• '.join(action_descriptions)),
 				type=message_type,
 				context=context)
 			self.record_warning(message.author)

rocketbot/cogs/urlspamcog.py

@@ -129,7 +129,7 @@ class URLSpamCog(BaseCog, name='URL Spam'):
 			bm = BotMessage(
 					message.guild,
 					f'User {message.author.mention} posted a URL ' + \
-					f'{join_age_str} after joining.',
+					f'{join_age_str} after joining: {message.jump_url}',
 					type = BotMessage.TYPE_MOD_WARNING if needs_attention else BotMessage.TYPE_INFO,
 					context = context)
 			bm.quote = discordutils.remove_markdown(message.clean_content)
@@ -152,7 +152,7 @@ class URLSpamCog(BaseCog, name='URL Spam'):
 
 		if not self.contains_deceptive_links(message.content):
 			return
-		mod_text = f'User {message.author.name} ({message.author.id}) posted a deceptive link.'
+		mod_text = f'User {message.author.name} ({message.author.id}) posted a deceptive link. {message.jump_url}'
 		quoted = '> ' + escape_markdown(message.content).replace('\n', '\n> ')
 		mod_text += f'\n\n{quoted}'
 		self.log(message.guild, f'{message.author.name} posted deceptive link - action: {action}')