Experimental Discord bot written in Python
You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

crosspostcog.py 15KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372
  1. """
  2. Cog for detecting spam messages posted in multiple channels.
  3. """
  4. import re
  5. from datetime import datetime, timedelta
  6. from typing import Optional
  7. from discord import Member, Message, TextChannel
  8. from discord import utils as discordutils
  9. from discord.ext.commands import Cog
  10. from config import CONFIG
  11. from rocketbot.cogs.basecog import BaseCog, BotMessage, BotMessageReaction, CogSetting
  12. from rocketbot.collections import AgeBoundDict, AgeBoundList
  13. from rocketbot.storage import Storage
  14. from rocketbot.utils import str_from_timedelta
  15. class SpamContext:
  16. """
  17. Data about a set of duplicate messages from a user.
  18. """
  19. def __init__(self, member: Member) -> None:
  20. self.member: Member = member
  21. self.age: datetime = datetime.now()
  22. self.bot_message: Optional[BotMessage] = None
  23. self.is_kicked: bool = False
  24. self.is_banned: bool = False
  25. self.is_autobanned: bool = False
  26. self.spam_messages: set[Message] = set()
  27. self.deleted_messages: set[Message] = set()
  28. self.unique_channels: set[TextChannel] = set()
  29. self.duplicate_count: int = 0
  30. class CrossPostCog(BaseCog, name='Crosspost Detection'):
  31. """
  32. Detects a user posting in multiple channels in a short period
  33. of time: a common pattern for spammers.
  34. """
  35. SETTING_ENABLED = CogSetting(
  36. 'enabled',
  37. bool,
  38. default_value=False,
  39. brief='crosspost detection',
  40. description='Whether crosspost detection is enabled.',
  41. )
  42. SETTING_WARN_COUNT = CogSetting(
  43. 'warncount',
  44. int,
  45. default_value=5,
  46. brief='number of messages to trigger a warning',
  47. description='The number of unique channels messages are ' + \
  48. 'posted in by the same user to trigger a mod warning. The ' + \
  49. 'messages need not be identical (see dupewarncount).',
  50. min_value=2,
  51. )
  52. SETTING_DUPE_WARN_COUNT = CogSetting(
  53. 'dupewarncount',
  54. int,
  55. default_value=3,
  56. brief='number of identical messages to trigger a warning',
  57. description='The number of unique channels identical messages are ' + \
  58. 'posted in by the same user to trigger a mod warning.',
  59. min_value=2,
  60. )
  61. SETTING_BAN_COUNT = CogSetting(
  62. 'bancount',
  63. int,
  64. default_value=9999,
  65. brief='number of messages to trigger a ban',
  66. description='The number of unique channels messages are ' + \
  67. 'posted in by the same user to trigger an automatic ban. The ' + \
  68. 'messages need not be identical (see dupebancount). Set ' + \
  69. 'to a large value to effectively disable, e.g. 9999.',
  70. min_value=2,
  71. )
  72. SETTING_DUPE_BAN_COUNT = CogSetting(
  73. 'dupebancount',
  74. int,
  75. default_value=9999,
  76. brief='number of identical messages to trigger a ban',
  77. description='The number of unique channels identical messages are ' + \
  78. 'posted in by the same user to trigger an automatic ban. Set ' + \
  79. 'to a large value to effectively disable, e.g. 9999.',
  80. min_value=2,
  81. )
  82. SETTING_MIN_LENGTH = CogSetting(
  83. 'minlength',
  84. int,
  85. default_value=1,
  86. brief='minimum message length',
  87. description='The minimum number of characters in a message to be ' + \
  88. 'checked for duplicates. This can help ignore common short ' + \
  89. 'messages like "lol" or a single emoji.',
  90. min_value=1,
  91. )
  92. SETTING_TIMESPAN = CogSetting(
  93. 'timespan',
  94. timedelta,
  95. default_value=timedelta(seconds=60),
  96. brief='time window to look for dupe messages',
  97. description='The number of seconds of message history to look at '
  98. 'when looking for duplicates. Shorter values are preferred, '
  99. 'both to detect bots and avoid excessive memory usage.',
  100. min_value=timedelta(seconds=1),
  101. )
  102. STATE_KEY_RECENT_MESSAGES = "CrossPostCog.recent_messages"
  103. STATE_KEY_SPAM_CONTEXT = "CrossPostCog.spam_context"
  104. def __init__(self, bot):
  105. super().__init__(
  106. bot,
  107. config_prefix='crosspost',
  108. short_description='Manages crosspost detection and handling.',
  109. long_description='Detects a user posting in multiple channels in a short period of '
  110. 'time: a common pattern for spammers.\n'
  111. '\n'
  112. "These used to be identical text, but more recent attacks have had "
  113. "small variations, such as different imgur URLs. It's reasonable to "
  114. "treat posting in many channels in a short period as suspicious on its "
  115. "own, regardless of whether they are identical.\n"
  116. "\n"
  117. "Repeated posts in the same channel aren't currently detected, as "
  118. "this can often be for a reason or due to trying a failed post when "
  119. "connectivity is poor. Minimum message length can be enforced for "
  120. "detection.",
  121. )
  122. self.add_setting(CrossPostCog.SETTING_ENABLED)
  123. self.add_setting(CrossPostCog.SETTING_WARN_COUNT)
  124. self.add_setting(CrossPostCog.SETTING_DUPE_WARN_COUNT)
  125. self.add_setting(CrossPostCog.SETTING_BAN_COUNT)
  126. self.add_setting(CrossPostCog.SETTING_DUPE_BAN_COUNT)
  127. self.add_setting(CrossPostCog.SETTING_MIN_LENGTH)
  128. self.add_setting(CrossPostCog.SETTING_TIMESPAN)
  129. self.max_spam_contexts = 12
  130. async def __record_message(self, message: Message) -> None:
  131. if message.channel.permissions_for(message.author).ban_members:
  132. # User exempt from spam detection
  133. self.__trace("User exempt from crosspost checks")
  134. return
  135. def compute_message_hash(m: Message) -> int:
  136. to_hash = m.content
  137. # URLs sometimes differ per spam message, so simplify them
  138. url_regex = r'http[s]?://(?:[a-zA-Z]|[0-9]|[$-_@.&+]|[!*\(\),]|(?:%[0-9a-fA-F][0-9a-fA-F]))+'
  139. to_hash = re.sub(url_regex, '<url>', to_hash)
  140. # Add attachment metadata
  141. for attachment in m.attachments:
  142. to_hash += f'\n[[ATT: ct={attachment.content_type} s={attachment.size} w={attachment.width} h={attachment.height}]]'
  143. h = hash(to_hash)
  144. self.__trace(f"Message hash for {m.id} is {h}")
  145. return h
  146. min_length = self.get_guild_setting(message.guild, self.SETTING_MIN_LENGTH)
  147. if len(message.attachments) == 0 and len(message.content) < min_length:
  148. # Message too short to count towards spam total
  149. self.__trace(f"Message len {len(message.content)} < {min_length}")
  150. return
  151. # Get config
  152. max_age = timedelta(seconds=self.get_guild_setting(message.guild, self.SETTING_TIMESPAN))
  153. warn_count: int = self.get_guild_setting(message.guild, self.SETTING_WARN_COUNT)
  154. dupe_warn_count: int = self.get_guild_setting(message.guild, self.SETTING_DUPE_WARN_COUNT)
  155. # Record message
  156. recent_messages: AgeBoundList[Message, datetime, timedelta] = Storage.get_state_value(message.guild, self.STATE_KEY_RECENT_MESSAGES)
  157. if recent_messages is None:
  158. recent_messages = AgeBoundList(max_age, lambda index, message : message.created_at)
  159. Storage.set_state_value(message.guild, self.STATE_KEY_RECENT_MESSAGES, recent_messages)
  160. recent_messages.max_age = max_age
  161. recent_messages.append(message)
  162. self.__trace(f"Recent messages now length {len(recent_messages)}")
  163. # Get all recent messages by user
  164. member_messages = [m for m in recent_messages if m.author.id == message.author.id]
  165. message_count = len(member_messages)
  166. self.__trace(f"Found {message_count} messages for {message.author.name}")
  167. if message_count < warn_count and message_count < dupe_warn_count:
  168. self.__trace(f"Bailing because message count {message_count} < warn count {warn_count} and < dupe warn count {dupe_warn_count}")
  169. return
  170. # Look for identical(ish) messages and unique channels
  171. hash_to_channels: dict[int, set[TextChannel]] = {}
  172. unique_channels: set[TextChannel] = set()
  173. max_duplicate_count = 0
  174. for m in member_messages:
  175. message_hash = compute_message_hash(m)
  176. dupe_message_channels: set[TextChannel] = hash_to_channels.get(message_hash)
  177. if dupe_message_channels is None:
  178. dupe_message_channels = set()
  179. hash_to_channels[message_hash] = dupe_message_channels
  180. dupe_message_channels.add(m.channel)
  181. unique_channels.add(m.channel)
  182. max_duplicate_count = max(max_duplicate_count, len(dupe_message_channels))
  183. channel_count = len(unique_channels)
  184. self.__trace(f"Found {len(hash_to_channels)} unique messages, {channel_count} unique channels, {max_duplicate_count} duplicated messages")
  185. if channel_count < warn_count and max_duplicate_count < dupe_warn_count:
  186. self.__trace(f"Bailing because channels {channel_count} < warn count {warn_count} and max dupes {max_duplicate_count} < dupe warn count {dupe_warn_count}")
  187. return
  188. # This person is a problem
  189. spam_lookup: AgeBoundDict[str, SpamContext, datetime, timedelta] = Storage.get_state_value(message.guild, self.STATE_KEY_SPAM_CONTEXT)
  190. if spam_lookup is None:
  191. spam_lookup = AgeBoundDict(
  192. max_age,
  193. lambda key, context : context.age)
  194. Storage.set_state_value(message.guild, self.STATE_KEY_SPAM_CONTEXT, spam_lookup)
  195. key = f'{message.author.id}'
  196. context = spam_lookup.get(key)
  197. if context is not None and message.created_at - context.age > max_age:
  198. context = None
  199. if context is None:
  200. context = SpamContext(message.author)
  201. spam_lookup[key] = context
  202. self.log(message.guild,
  203. f'\u0007{message.author.name} ({message.author.id}) ' + \
  204. f'posted messages in {channel_count} channels.')
  205. context.age = message.created_at
  206. context.duplicate_count = max_duplicate_count
  207. context.spam_messages.update(member_messages)
  208. context.unique_channels.update(unique_channels)
  209. await self.__update_from_context(context)
  210. async def __update_from_context(self, context: SpamContext):
  211. ban_count = self.get_guild_setting(context.member.guild, self.SETTING_BAN_COUNT)
  212. dupe_ban_count = self.get_guild_setting(context.member.guild, self.SETTING_DUPE_BAN_COUNT)
  213. channel_count = len(context.unique_channels)
  214. if channel_count >= ban_count or context.duplicate_count >= dupe_ban_count:
  215. if not context.is_banned:
  216. max_age = timedelta(seconds=self.get_guild_setting(context.member.guild, self.SETTING_TIMESPAN))
  217. max_age_str = str_from_timedelta(max_age)
  218. await context.member.ban(
  219. reason=f'Rocketbot: Posted in {channel_count} channels within {max_age_str} ' + \
  220. f'({context.duplicate_count} identical). Banned by {self.bot.user.name}.',
  221. delete_message_days=1)
  222. context.is_kicked = True
  223. context.is_banned = True
  224. context.is_autobanned = True
  225. context.deleted_messages |= context.spam_messages
  226. self.__log_ban(context, self.bot.user.name)
  227. else:
  228. # Already banned. Nothing to update in the message.
  229. return
  230. await self.__update_message_from_context(context)
  231. async def __update_message_from_context(self, context: SpamContext) -> None:
  232. first_spam_message: Message = sorted(list(context.spam_messages), key=lambda m: m.created_at)[0]
  233. spam_count = len(context.spam_messages)
  234. channel_count = len(context.unique_channels)
  235. deleted_count = len(context.deleted_messages)
  236. duplicate_count = context.duplicate_count
  237. max_age = timedelta(seconds=self.get_guild_setting(context.member.guild, self.SETTING_TIMESPAN))
  238. max_age_str = str_from_timedelta(max_age)
  239. message = context.bot_message
  240. if message is None:
  241. message_type: int = BotMessage.TYPE_INFO if self.was_warned_recently(context.member) \
  242. else BotMessage.TYPE_MOD_WARNING
  243. message = BotMessage(context.member.guild, '', message_type, context)
  244. message.quote = discordutils.remove_markdown(first_spam_message.clean_content)
  245. self.record_warning(context.member)
  246. if context.is_autobanned:
  247. text = f'User {context.member.mention} auto banned for ' + \
  248. f'posting messages in {channel_count} channels within {max_age_str} ' + \
  249. f'({duplicate_count} identical). Messages from past 24 hours deleted.'
  250. await message.set_reactions([])
  251. await message.set_text(text)
  252. else:
  253. body: str = f'User {context.member.mention} posted '
  254. if duplicate_count == channel_count:
  255. body += f'identical messages in {channel_count} channels within {max_age_str} .'
  256. elif duplicate_count == 1:
  257. body += f'**different** messages in {channel_count} channels within ' + \
  258. f'{max_age_str}. (Showing first one).'
  259. else:
  260. body += f'messages in {channel_count} channels within {max_age_str} ' + \
  261. f'({duplicate_count} are identical, showing first one).'
  262. max_links = 10
  263. for msg in sorted(list(context.spam_messages), key=lambda m: m.created_at)[:max_links]:
  264. body += f'\n- {msg.jump_url}'
  265. if len(context.spam_messages) > max_links:
  266. body += f'\n- ...{len(context.spam_messages) - max_links} more...'
  267. await message.set_text(body)
  268. await message.set_reactions(BotMessageReaction.standard_set(
  269. did_delete = deleted_count >= spam_count,
  270. message_count = spam_count,
  271. did_kick = context.is_kicked,
  272. did_ban = context.is_banned))
  273. if context.bot_message is None:
  274. await self.post_message(message)
  275. context.bot_message = message
  276. async def on_mod_react(self,
  277. bot_message: BotMessage,
  278. reaction: BotMessageReaction,
  279. reacted_by: Member) -> None:
  280. context: SpamContext = bot_message.context
  281. if context is None:
  282. return
  283. channel_count = len(context.unique_channels)
  284. if reaction.emoji == CONFIG['trash_emoji']:
  285. for message in context.spam_messages - context.deleted_messages:
  286. await message.delete()
  287. context.deleted_messages.add(message)
  288. await self.__update_from_context(context)
  289. self.__log_deletion(context, reacted_by.name)
  290. elif reaction.emoji == CONFIG['kick_emoji']:
  291. await context.member.kick(
  292. reason=f'Rocketbot: Posted messages in {channel_count} ' + \
  293. f'channels. Kicked by {reacted_by.name}.')
  294. context.is_kicked = True
  295. await self.__update_from_context(context)
  296. self.__log_kick(context, reacted_by.name)
  297. elif reaction.emoji == CONFIG['ban_emoji']:
  298. await context.member.ban(
  299. reason=f'Rocketbot: Posted messages in {channel_count} ' + \
  300. f'channels. Banned by {reacted_by.name}.',
  301. delete_message_days=1)
  302. context.deleted_messages |= context.spam_messages
  303. context.is_kicked = True
  304. context.is_banned = True
  305. await self.__update_from_context(context)
  306. self.__log_ban(context, reacted_by.name)
  307. def __log_deletion(self, context: SpamContext, by_who: str) -> None:
  308. max_age = timedelta(seconds=self.get_guild_setting(context.member.guild, self.SETTING_TIMESPAN))
  309. max_age_str = str_from_timedelta(max_age)
  310. channel_count = len(context.unique_channels)
  311. duplicate_count = context.duplicate_count
  312. self.log(context.member.guild,
  313. f'{context.member.name} ({context.member.id}) posted ' + \
  314. f'messages in {channel_count} channels withint {max_age_str} ' + \
  315. f'({duplicate_count} identical). Deleted by {by_who}.')
  316. def __log_kick(self, context: SpamContext, by_who: str) -> None:
  317. max_age = timedelta(seconds=self.get_guild_setting(context.member.guild, self.SETTING_TIMESPAN))
  318. max_age_str = str_from_timedelta(max_age)
  319. channel_count = len(context.unique_channels)
  320. duplicate_count = context.duplicate_count
  321. self.log(context.member.guild,
  322. f'{context.member.name} ({context.member.id}) posted ' + \
  323. f'messages in {channel_count} channels within {max_age_str} ' + \
  324. f'({duplicate_count} identical). Kicked by {by_who}.')
  325. def __log_ban(self, context: SpamContext, by_who: str) -> None:
  326. max_age = timedelta(seconds=self.get_guild_setting(context.member.guild, self.SETTING_TIMESPAN))
  327. max_age_str = str_from_timedelta(max_age)
  328. channel_count = len(context.unique_channels)
  329. duplicate_count = context.duplicate_count
  330. self.log(context.member.guild,
  331. f'{context.member.name} ({context.member.id}) posted ' + \
  332. f'messages in {channel_count} channels within {max_age_str} ' + \
  333. f'({duplicate_count} identical). Banned by {by_who}.')
  334. def __trace(self, message):
  335. # print(message)
  336. pass
  337. @Cog.listener()
  338. async def on_message(self, message: Message):
  339. """Event handler"""
  340. if message.author is None or \
  341. message.author.bot or \
  342. message.channel is None or \
  343. message.guild is None:
  344. return
  345. if not self.get_guild_setting(message.guild, self.SETTING_ENABLED):
  346. return
  347. self.__trace("--ON MESSAGE--")
  348. await self.__record_message(message)