Adding partial/broken expression testing for spreadsheet

jstest/spreadsheet/ExpressionSetTests.js

@@ -212,4 +212,84 @@ class ExpressionSetTests extends BaseTest {
 		this._test_simple_formula(new CellValue('271.83%', 2.718281828459045, 'percent', 2), '=2.718281828459045 ; percent 2');
 		this._test_simple_formula(new CellValue('$2.72', 2.718281828459045, 'currency', 2), '=2.718281828459045 ; currency 2');
 	}
+
+	#iterateCharacters(formula, testFinal=false) {
+		for (var i = 1; i < formula.length; i++) {
+			const portion = formula.substring(0, i);
+			const grid = new SpreadsheetGrid(1, 1);
+			grid.cells[0][0].originalValue = CellValue.fromCellString(portion);
+			const expressionSet = new CellExpressionSet(grid);
+			expressionSet.calculateCells();
+		}
+		if (testFinal) {
+			const grid = new SpreadsheetGrid(1, 1);
+			grid.cells[0][0].originalValue = CellValue.fromCellString(formula);
+			const expressionSet = new CellExpressionSet(grid);
+			expressionSet.calculateCells();
+			const actual = grid.cells[0][0].outputValue;
+			if (actual === null) {
+				this.fail(`Expected \"${formula}\" to evaluate to a value, got null`);
+			} else if (actual.type === CellValue.TYPE_ERROR) {
+				this.fail(`Expected \"${formula}\" to evaluate to a value, got error ${actual.value.message}`);
+			}
+		}
+	}
+
+	test_partialAndBrokenSyntax() {
+		// Like `BrokenSyntaxTests`, this tries parsing a bunch of cell values
+		// character by character like an author typing them in and makes sure
+		// they don't throw exceptions. The `true` flag will do a simple check
+		// that the final complete expression evaluates to something other than
+		// `null` or an error.
+		this.#iterateCharacters("123", true);
+		this.#iterateCharacters("-123", true);
+		this.#iterateCharacters("true", true);
+		this.#iterateCharacters("false", true);
+		this.#iterateCharacters("TrUe", true);
+		this.#iterateCharacters("fAlSe", true);
+		this.#iterateCharacters("$123.45", true);
+		this.#iterateCharacters("-$123.45", true);
+		this.#iterateCharacters("12.34%", true);
+		this.#iterateCharacters("-12.34%", true);
+		this.#iterateCharacters("'01234", true);
+		this.#iterateCharacters("'  ", true);
+		this.#iterateCharacters("Foo bar", true);
+		this.#iterateCharacters("=====");
+		this.#iterateCharacters("=1*2*3*4", true);
+		this.#iterateCharacters("=1**2");
+		this.#iterateCharacters("=**123");
+		this.#iterateCharacters("=6+*3");
+		this.#iterateCharacters("=)))");
+		this.#iterateCharacters("=(3*)");
+		this.#iterateCharacters("=(*3)");
+		this.#iterateCharacters("=(((");
+		this.#iterateCharacters("=\")");
+		this.#iterateCharacters("=-123", true);
+		this.#iterateCharacters("=--123");
+		this.#iterateCharacters("=---123");
+		this.#iterateCharacters("=-\"str\"");
+		this.#iterateCharacters("=\"str\"&3", true);
+		this.#iterateCharacters("=1<3", true);
+		this.#iterateCharacters("=1<=3", true);
+		this.#iterateCharacters("=1>3", true);
+		this.#iterateCharacters("=1>=3", true);
+		this.#iterateCharacters("=1==3", true);
+		this.#iterateCharacters("=1!=3", true);
+		this.#iterateCharacters("=>=3");
+		this.#iterateCharacters("=<=3");
+		this.#iterateCharacters("=!=3");
+		this.#iterateCharacters("=MAX)");
+		this.#iterateCharacters("=MAX(3,,)");
+		this.#iterateCharacters("=MAX(\"a\",\"b\")");
+		this.#iterateCharacters("=ZZ999");
+		this.#iterateCharacters("=$ZZ999");
+		this.#iterateCharacters("=ZZ$999");
+		this.#iterateCharacters("=$ZZ$999");
+		this.#iterateCharacters("=1+2", true);
+		this.#iterateCharacters("=1-2", true);
+		this.#iterateCharacters("=1*2", true);
+		this.#iterateCharacters("=1/2", true);
+		this.#iterateCharacters("=A1(1)");
+		this.#iterateCharacters("=$A$1(1)");
+	}
 }

markdown.md

@@ -372,6 +372,8 @@ Class:
 
 Formats that apply within a block to style runs of words or inject other content within text.
 
+To prevent a punctuation character from being interpreted as formatting syntax, prefix the character with a backslash (`\\`). E.g. `3\*4\*2=24` is rendered as "3\*4\*2=24", not as "3*4*2=24".
+
 ### Strong
 
 Text can be marked as bold by enclosing it in double asterisks.

phptest/spreadsheet/ExpressionSetTests.php

@@ -228,5 +228,86 @@ final class ExpressionSetTests extends TestCase {
 		$this->test_simple_formula(new CellValue('271.83%', 2.718281828459045, 'percent', 2), '=2.718281828459045 ; percent 2');
 		$this->test_simple_formula(new CellValue('$2.72', 2.718281828459045, 'currency', 2), '=2.718281828459045 ; currency 2');
 	}
+
+	private function iterateCharacters(string $formula, bool $testFinal=false) {
+		for ($i = 1; $i < mb_strlen($formula); $i++) {
+			$portion = mb_substr($formula, 0, $i);
+			$grid = new SpreadsheetGrid(1, 1);
+			$grid->cells[0][0]->originalValue = CellValue::fromCellString($portion);
+			$expressionSet = new CellExpressionSet($grid);
+			$expressionSet->calculateCells();
+		}
+		if ($testFinal) {
+			$grid = new SpreadsheetGrid(1, 1);
+			$grid->cells[0][0]->originalValue = CellValue::fromCellString($formula);
+			$expressionSet = new CellExpressionSet($grid);
+			$expressionSet->calculateCells();
+			$actual = $grid->cells[0][0]->outputValue;
+			if ($actual === null) {
+				$this->fail("Expected \"{$formula}\" to evaluate to a value, got null");
+			} elseif ($actual->type === CellValue::TYPE_ERROR) {
+				$this->fail("Expected \"{$formula}\" to evaluate to a value, got error {$actual->value->getMessage()}");
+			}
+		}
+	}
+
+	public function test_partialAndBrokenSyntax() {
+		// Like `BrokenSyntaxTests`, this tries parsing a bunch of cell values
+		// character by character like an author typing them in and makes sure
+		// they don't throw exceptions. The `true` flag will do a simple check
+		// that the final complete expression evaluates to something other than
+		// `null` or an error.
+		$this->iterateCharacters("123", true);
+		$this->iterateCharacters("-123", true);
+		$this->iterateCharacters("true", true);
+		$this->iterateCharacters("false", true);
+		$this->iterateCharacters("TrUe", true);
+		$this->iterateCharacters("fAlSe", true);
+		$this->iterateCharacters("$123.45", true);
+		$this->iterateCharacters("-$123.45", true);
+		$this->iterateCharacters("12.34%", true);
+		$this->iterateCharacters("-12.34%", true);
+		$this->iterateCharacters("'01234", true);
+		$this->iterateCharacters("'  ", true);
+		$this->iterateCharacters("Foo bar", true);
+		$this->iterateCharacters("=====");
+		$this->iterateCharacters("=1*2*3*4", true);
+		$this->iterateCharacters("=1**2");
+		$this->iterateCharacters("=**123");
+		$this->iterateCharacters("=6+*3");
+		$this->iterateCharacters("=)))");
+		$this->iterateCharacters("=(3*)");
+		$this->iterateCharacters("=(*3)");
+		$this->iterateCharacters("=(((");
+		$this->iterateCharacters("=\")");
+		$this->iterateCharacters("=-123", true);
+		$this->iterateCharacters("=--123");
+		$this->iterateCharacters("=---123");
+		$this->iterateCharacters("=-\"str\"");
+		$this->iterateCharacters("=\"str\"&3", true);
+		$this->iterateCharacters("=1<3", true);
+		$this->iterateCharacters("=1<=3", true);
+		$this->iterateCharacters("=1>3", true);
+		$this->iterateCharacters("=1>=3", true);
+		$this->iterateCharacters("=1==3", true);
+		$this->iterateCharacters("=1!=3", true);
+		$this->iterateCharacters("=>=3");
+		$this->iterateCharacters("=<=3");
+		$this->iterateCharacters("=!=3");
+		$this->iterateCharacters("=MAX)");
+		$this->iterateCharacters("=MAX(3,,)");
+		$this->iterateCharacters("=MAX(\"a\",\"b\")");
+		$this->iterateCharacters("=ZZ999");
+		$this->iterateCharacters('=$ZZ999');
+		$this->iterateCharacters('=ZZ$999');
+		$this->iterateCharacters('=$ZZ$999');
+		$this->iterateCharacters("=1+2", true);
+		$this->iterateCharacters("=1-2", true);
+		$this->iterateCharacters("=1*2", true);
+		$this->iterateCharacters("=1/2", true);
+		$this->iterateCharacters("=A1(1)");
+		$this->iterateCharacters('=$A$1(1)');
+		$this->assertTrue(true); // to satisfy PHPUnit
+	}
 }
 ?>